fix: restore DefaultDictionaryPredictor so custom words appear in suggestions#342
Merged
bartekplus merged 4 commits intomasterfrom Mar 22, 2026
Merged
fix: restore DefaultDictionaryPredictor so custom words appear in suggestions#342bartekplus merged 4 commits intomasterfrom
bartekplus merged 4 commits intomasterfrom
Conversation
…iles The DefaultDictionaryPredictor was accidentally dropped from the PREDICTORS registry in all presage.xml files during the build script refactor (#204). As a result, custom words saved in Settings were written to disk but never queried by Presage, so they never appeared in suggestions. Fixes #341 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Repacked all language .data files and updated libpresage.js metadata after restoring DefaultDictionaryPredictor to presage.xml configs. Also documents the repack workflow in docs/agents/commands.md so it is clear when and how to repack after presage.xml changes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add 'bun run check' quality gate section to docs/agents/commands.md so agents know to run and pass the full check suite before every PR - Add scripts/.deps/** to eslint ignores to prevent generated build artifacts from being linted Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds a live test to PresageHandler.live.test.ts that verifies custom words in userDictionaryList appear in predictions. This would have caught the missing DefaultDictionaryPredictor registration. Also adds a regression test policy to docs/agents/testing.md: every bug fix must include a test that fails on unfixed code. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DefaultDictionaryPredictorto thePREDICTORSregistry in all 9 languagepresage.xmlfiles and the lang templateUserDictionaryManagerwas correctly writing words to disk and callinglibPresage.config(...), but without the predictor registered in the XML it was never activatedFixes #341
Test plan
🤖 Generated with Claude Code